Fordelingskomponenten#44
Open
rimi-itk wants to merge 1 commit into
Open
Conversation
rimi-itk
force-pushed
the
feature/SF2900-Fordelingskomponenten
branch
5 times, most recently
from
eafa49f to
72c2be0
Compare
rimi-itk
force-pushed
the
feature/SF2900-Fordelingskomponenten
branch
3 times, most recently
from
1747d57 to
9802bc4
Compare
rimi-itk
force-pushed
the
feature/SF2900-Fordelingskomponenten
branch
2 times, most recently
from
e4b5c32 to
4f45e16
Compare
rimi-itk
force-pushed
the
feature/SF2900-Fordelingskomponenten
branch
3 times, most recently
from
fa4f919 to
666180b
Compare
rimi-itk
force-pushed
the
feature/SF2900-Fordelingskomponenten
branch
from
666180b to
1445ead
Compare
jekuaitk
reviewed
May 12, 2026
Comment on lines
+39
to
+41
| if (null === $options['routing-kle']) { | ||
| throw new InvalidOptionException('Option "routing-kle" is required.'); | ||
| } |
Contributor
There was a problem hiding this comment.
Is this not caught by
new InputOption('routing-kle', null, InputOption::VALUE_REQUIRED, 'routing-kle'),in AbstractCommand::getDefinitionItems?
| ->setRequired('sftp') | ||
| ->setDefault('sftp', $resolveSftpOptions) | ||
| // Defining nested options via setDefault() is deprecated since Symfony 7.3 | ||
| // (cf. https://symfony.com/doc/current/components/options_resolver.html#nested-options) |
Contributor
There was a problem hiding this comment.
Suggested change
| // (cf. https://symfony.com/doc/current/components/options_resolver.html#nested-options) | |
| // (cf. https://symfony.com/doc/7.4/components/options_resolver.html#nested-options) |
|
|
||
| public function saveLastError(string $methodName, \SoapFault $soapFault): static | ||
| { | ||
| // Throw a SOAP exception rather than just storing a SOAP fault as the parent class does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Fordelingskomponenten.